Feat: Add Swift-wasm suppport to DataLoader #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottmarchant
force-pushed
the
feat/swift-wasm-support
branch
from
ac99271 to
7e2de10
Compare
32 tasks
scottmarchant
force-pushed
the
feat/swift-wasm-support
branch
from
7e2de10 to
ed27c6f
Compare
…tWasm. Removes broad NIO dependency from DataLoader module, as it actually depends only on NIOCore, not all of NIO.
…such as NIOCore and/or NIOPosix, rather than the much larger dependency of just NIO.
scottmarchant
force-pushed
the
feat/swift-wasm-support
branch
from
ed27c6f to
68720a6
Compare
NeedleInAJayStack
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for compiling DataLoader to wasm using the SwiftWasm sdk.
This PR is part of a larger effort by a company called PassiveLogic to enable broad support for SwiftWasm.
Details
Currently, NIOCore compiles to wasm, but NIOPosix and many other portions of NIO do not. The main change here is to isolate the main DataLoader module to use only NIOCore. The module was already using only NIOCore, but the imports and package configuration consumed all of NIO, breaking wasm compilation.
Testing done
Ran swift format per the contribution guide, and verified unit tests still pass with these changes. Also tested this change
Impact Risk
Realistically, this change should not cause any impact or risk. It does not change any public-facing code other than import sanitization and dependency cleanup.